-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch which makes the module work in Python 3 #16
Conversation
Any dev looking at this? I also get the error |
This can be more easily solved by modifying setup.py (see my pull request); upon installation the correct version of the condition will be in the code. |
|
MS-Position, can you give us a working example of the code that generates this error? |
I actually can not (see above). The patch does indeed work. |
I think this PR is not needed anymore since the Py3K problem was resolved with #15 |
I'd like to find a better way to do it than mutating basestring, but it does seem that this problem is solved at least for now |
We can look into six: https://pypi.python.org/pypi/six |
I made a new pull request which implements this using six: #32 |
And another that does the same thing without the need for six: #33 |
Here is a patch which makes the module work in Python 3..
isinstance(basestring)
raises a NameError in Python 3. because type ofbasestring
is not supported.